Differential D20448

Don't warn that workboard columns need a name when editing milestone columns
ClosedPublic
Actions

Authored by epriestley on Apr 18 2019, 12:31 PM.

Details

Reviewers

Commits

rPcd2215fd4a69: Don't warn that workboard columns need a name when editing milestone columns

Summary

See https://discourse.phabricator-community.org/t/columns-must-have-a-name-while-editong-point-limit-on-milestone-column/2650. This check doesn't make sense for proxy columns, including milestone columns.

Test Plan

Added a point limit to a milestone column.

Diff Detail

Repository

rP Phabricator

Branch

col1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22654
Build 31047: Run Core Tests
Build 31046: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 18 2019, 12:31 PM

Harbormaster completed remote builds in B22654: Diff 48782.Apr 18 2019, 12:33 PM

epriestley requested review of this revision.Apr 18 2019, 12:33 PM

amckinley accepted this revision.Apr 18 2019, 4:40 PM

This revision is now accepted and ready to land.Apr 18 2019, 4:40 PM

Closed by commit rPcd2215fd4a69: Don't warn that workboard columns need a name when editing milestone columns (authored by epriestley). · Explain WhyApr 18 2019, 8:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

xaction/

column/

PhabricatorProjectColumnNameTransaction.php

5 lines

Diff 48782

View Options

src/applications/project/xaction/column/PhabricatorProjectColumnNameTransaction.php

Don't warn that workboard columns need a name when editing milestone columnsClosedPublicActions