When an invalid "constraints" parameter is provided to a "*.search" method, raise a more tailored error
ClosedPublic
Actions

Authored by epriestley on Apr 15 2019, 6:50 PM.

Details

Reviewers

amckinley

Commits

rP382e2c32fc10: When an invalid "constraints" parameter is provided to a "*.search" method…

Summary

See https://discourse.phabricator-community.org/t/constraints-parameter-type-handling-in-maniphest-search/2636.

(The caller provided constraints={...} via cURL, but you can't mix JSON and HTTP parameters like that.)

Test Plan

Called curl 'http://local.phacility.com/api/maniphest.search?api.token=...&constraints=X' (with a valid API token), got a more sensible error.

Diff Detail

Repository

rP Phabricator

Branch

constraints1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22601
Build 30967: Run Core Tests
Build 30966: arc lint + arc unit

Event Timeline

epriestley created this revision.Apr 15 2019, 6:50 PM

Harbormaster completed remote builds in B22601: Diff 48731.Apr 15 2019, 6:51 PM

epriestley requested review of this revision.Apr 15 2019, 6:51 PM

amckinley accepted this revision.Apr 17 2019, 8:10 PM

This revision is now accepted and ready to land.Apr 17 2019, 8:10 PM

Closed by commit rP382e2c32fc10: When an invalid "constraints" parameter is provided to a "*.search" method… (authored by epriestley). · Explain WhyApr 17 2019, 8:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorApplicationSearchEngine.php

6 lines

Diff 48731

View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

When an invalid "constraints" parameter is provided to a "*.search" method, raise a more tailored errorClosedPublicActions