Page MenuHomePhabricator

Improve Conpherence behavior for logged out users.
ClosedPublic

Authored by amckinley on Apr 2 2019, 8:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 7, 5:28 AM
Unknown Object (File)
Feb 10 2024, 2:42 AM
Unknown Object (File)
Jan 5 2024, 7:14 PM
Unknown Object (File)
Dec 14 2023, 5:29 AM
Unknown Object (File)
Nov 30 2023, 5:31 AM
Unknown Object (File)
Nov 18 2023, 4:57 PM
Unknown Object (File)
Oct 25 2023, 4:46 PM
Unknown Object (File)
Sep 1 2023, 6:51 PM
Subscribers

Details

Summary

There are two issues here I was trying to fix:

  • Viewing /conpherence by logged out users on secure would generate an overheated query on ConpherenceThreadQuery secure has a ton of wacky threads with bogus names.
  • When a user views a specific thread that they don't have permission to see, we attempt to fetch the thread's transactions before applying policy filtering. If the thread has more than 1000 comments, that query will also overheat instead of returning a policy exception.

I fixed the first problem, but started trying to fix the second by moving the transaction fetch to didFilterPage but it broke in strange ways so I gave up.

Also fix a dangling qsprintf update.

Test Plan

Loaded threads and the Conpherence homepage with and without logged in users.

Diff Detail

Repository
rP Phabricator
Branch
conph-heat (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22474
Build 30771: Run Core Tests
Build 30770: arc lint + arc unit

Event Timeline

I fixed the first problem, but started trying to fix the second by moving the transaction fetch to didFilterPage but it broke in strange ways so I gave up.

do not worry some day we will make conpherence a good application with good programming code 😀

This revision is now accepted and ready to land.Apr 2 2019, 9:01 PM
This revision was automatically updated to reflect the committed changes.