Page MenuHomePhabricator

Improve Conpherence behavior for logged out users.
ClosedPublic

Authored by amckinley on Tue, Apr 2, 8:58 PM.

Details

Summary

There are two issues here I was trying to fix:

  • Viewing /conpherence by logged out users on secure would generate an overheated query on ConpherenceThreadQuery secure has a ton of wacky threads with bogus names.
  • When a user views a specific thread that they don't have permission to see, we attempt to fetch the thread's transactions before applying policy filtering. If the thread has more than 1000 comments, that query will also overheat instead of returning a policy exception.

I fixed the first problem, but started trying to fix the second by moving the transaction fetch to didFilterPage but it broke in strange ways so I gave up.

Also fix a dangling qsprintf update.

Test Plan

Loaded threads and the Conpherence homepage with and without logged in users.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

amckinley created this revision.Tue, Apr 2, 8:58 PM
amckinley requested review of this revision.Tue, Apr 2, 8:59 PM
epriestley accepted this revision.Tue, Apr 2, 9:01 PM

I fixed the first problem, but started trying to fix the second by moving the transaction fetch to didFilterPage but it broke in strange ways so I gave up.

do not worry some day we will make conpherence a good application with good programming code ๐Ÿ˜€

This revision is now accepted and ready to land.Tue, Apr 2, 9:01 PM
This revision was automatically updated to reflect the committed changes.