Page MenuHomePhabricator

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic

Authored by epriestley on Apr 1 2019, 5:40 PM.
Tags
None
Referenced Files
F20632927: D20363.diff
Sat, Jun 20, 7:12 PM
F20604462: D20363.diff
Sat, Jun 20, 5:56 AM
Unknown Object (File)
Sun, May 31, 2:34 PM
Unknown Object (File)
Sun, May 31, 2:34 PM
Unknown Object (File)
Apr 18 2026, 5:08 PM
Unknown Object (File)
Apr 17 2026, 11:00 PM
Unknown Object (File)
Apr 16 2026, 7:44 AM
Unknown Object (File)
Apr 16 2026, 7:43 AM
Subscribers
None

Details

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository
rP Phabricator
Branch
context1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22456
Build 30741: Run Core Tests
Build 30740: arc lint + arc unit