Page MenuHomePhabricator

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic

Authored by epriestley on Apr 1 2019, 5:40 PM.
Tags
None
Referenced Files
F13082214: D20363.diff
Wed, Apr 24, 10:03 PM
Unknown Object (File)
Sun, Apr 21, 4:09 PM
Unknown Object (File)
Wed, Apr 17, 3:12 PM
Unknown Object (File)
Thu, Apr 11, 7:20 AM
Unknown Object (File)
Sun, Apr 7, 2:46 AM
Unknown Object (File)
Mar 25 2024, 7:50 AM
Unknown Object (File)
Jan 7 2024, 11:19 AM
Unknown Object (File)
Dec 24 2023, 4:36 PM
Subscribers
None

Details

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository
rP Phabricator
Branch
context1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22456
Build 30741: Run Core Tests
Build 30740: arc lint + arc unit