Page MenuHomePhabricator

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic

Authored by epriestley on Apr 1 2019, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 2:03 PM
Unknown Object (File)
Tue, Nov 26, 6:34 AM
Unknown Object (File)
Oct 24 2024, 7:46 AM
Unknown Object (File)
Oct 22 2024, 10:26 AM
Unknown Object (File)
Oct 13 2024, 8:35 PM
Unknown Object (File)
Sep 3 2024, 11:50 AM
Unknown Object (File)
Aug 31 2024, 10:42 PM
Unknown Object (File)
Aug 31 2024, 4:58 PM
Subscribers
None

Details

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository
rP Phabricator
Branch
context1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22456
Build 30741: Run Core Tests
Build 30740: arc lint + arc unit