Page MenuHomePhabricator

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic

Authored by epriestley on Apr 1 2019, 5:40 PM.
Tags
None
Referenced Files
F19840796: D20363.id.diff
Wed, Mar 11, 7:52 PM
F19814908: D20363.id48589.diff
Wed, Mar 4, 4:29 PM
F19792338: D20363.id48589.diff
Thu, Feb 26, 11:00 AM
F19792137: D20363.id48583.diff
Thu, Feb 26, 8:20 AM
F19391130: D20363.diff
Dec 27 2025, 6:20 AM
F18795526: D20363.id48583.diff
Oct 17 2025, 2:07 AM
F18628353: D20363.id.diff
Sep 16 2025, 6:11 AM
F18597044: D20363.diff
Sep 13 2025, 2:02 AM
Subscribers
None

Details

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable