Page MenuHomePhabricator

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic

Authored by epriestley on Apr 1 2019, 5:40 PM.
Tags
None
Referenced Files
F18795526: D20363.id48583.diff
Fri, Oct 17, 2:07 AM
F18628353: D20363.id.diff
Sep 16 2025, 6:11 AM
F18597044: D20363.diff
Sep 13 2025, 2:02 AM
F18518623: D20363.diff
Sep 5 2025, 3:27 PM
F18157989: D20363.id48589.diff
Aug 14 2025, 10:37 PM
F18107955: D20363.diff
Aug 11 2025, 4:03 AM
Unknown Object (File)
Jun 29 2025, 12:38 AM
Unknown Object (File)
Jun 27 2025, 3:07 AM
Subscribers
None

Details

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable