Paths

Table of Contentst

Differential D20363

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic
Actions

Authored by epriestley on Apr 1 2019, 5:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 12, 1:11 AM

	Unknown Object (File)
	Wed, May 7, 3:09 PM

	Unknown Object (File)
	Fri, May 2, 3:04 AM

	Unknown Object (File)
	Wed, Apr 30, 1:29 PM

	Unknown Object (File)
	Fri, Apr 18, 11:22 AM

	Unknown Object (File)
	Apr 13 2025, 8:44 PM

	Unknown Object (File)
	Apr 13 2025, 1:43 PM

	Unknown Object (File)
	Apr 12 2025, 7:55 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPcddbe306f927: Correct a case where a single-hunk diff may incorrectly be identified as multi…

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 1 2019, 5:40 PM

Harbormaster completed remote builds in B22456: Diff 48583.Apr 1 2019, 5:42 PM

epriestley requested review of this revision.Apr 1 2019, 5:42 PM

amckinley accepted this revision.Apr 1 2019, 6:05 PM

This revision is now accepted and ready to land.Apr 1 2019, 6:05 PM

Closed by commit rPcddbe306f927: Correct a case where a single-hunk diff may incorrectly be identified as multi… (authored by epriestley). · Explain WhyApr 1 2019, 9:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetRenderer.php

7 lines

Diff 48589

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engineClosedPublicActions