Paths

Table of Contentst

Differential D20363

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engine
ClosedPublic
Actions

Authored by epriestley on Apr 1 2019, 5:40 PM.

Tags

None

Referenced Files

	F15401901: D20363.id48583.diff
	Mon, Mar 17, 7:42 PM

	Unknown Object (File)
	Feb 15 2025, 2:36 AM

	Unknown Object (File)
	Jan 31 2025, 11:10 PM

	Unknown Object (File)
	Jan 21 2025, 8:31 PM

	Unknown Object (File)
	Jan 17 2025, 11:58 PM

	Unknown Object (File)
	Dec 26 2024, 10:53 AM

	Unknown Object (File)
	Dec 24 2024, 5:26 PM

	Unknown Object (File)
	Dec 23 2024, 7:34 PM

View All 100 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPcddbe306f927: Correct a case where a single-hunk diff may incorrectly be identified as multi…

Summary

See PHI985. The layers above this may return array() to mean "one hunk with a line-1 offset". Accept either array() or array(1 => ...) to engage the scope engine.

Test Plan

See PHI985.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Apr 1 2019, 5:40 PM

Harbormaster completed remote builds in B22456: Diff 48583.Apr 1 2019, 5:42 PM

epriestley requested review of this revision.Apr 1 2019, 5:42 PM

amckinley accepted this revision.Apr 1 2019, 6:05 PM

This revision is now accepted and ready to land.Apr 1 2019, 6:05 PM

Closed by commit rPcddbe306f927: Correct a case where a single-hunk diff may incorrectly be identified as multi… (authored by epriestley). · Explain WhyApr 1 2019, 9:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetRenderer.php

7 lines

Diff 48589

View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

Correct a case where a single-hunk diff may incorrectly be identified as multi-hunk by the Scope engineClosedPublicActions