Page MenuHomePhabricator

Give the "Code" tab in Diffusion more consistent (path-retaining) behavior
ClosedPublic

Authored by epriestley on Mar 25 2019, 9:34 PM.
Tags
None
Referenced Files
F14080895: D20323.diff
Fri, Nov 22, 5:20 PM
Unknown Object (File)
Mon, Nov 18, 4:49 PM
Unknown Object (File)
Wed, Nov 13, 9:30 PM
Unknown Object (File)
Sun, Nov 10, 10:15 AM
Unknown Object (File)
Wed, Nov 6, 6:03 AM
Unknown Object (File)
Tue, Nov 5, 7:00 AM
Unknown Object (File)
Tue, Oct 29, 4:44 AM
Unknown Object (File)
Tue, Oct 29, 4:05 AM
Subscribers
None

Details

Summary

Fixes T13270. In Diffusion, the "Code" tab is linked in a weird way that isn't consistent with the other tabs.

Particularly, if you navigate to x/y/z/ and toggle between the "Branches" and "History" tabs (or other tabs), you keep your path. If you click "Code", you lose your path.

Instead, retain the path, so you can navigate somewhere and then toggle to/from the "Code" tab to get different views of the same path.

Test Plan

Browed into a repository, clicked "History", clicked "Code", ended up back in the place I started.

Diff Detail

Repository
rP Phabricator
Branch
diffusion1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22378
Build 30615: Run Core Tests
Build 30614: arc lint + arc unit