Page MenuHomePhabricator

Give the "Code" tab in Diffusion more consistent (path-retaining) behavior
ClosedPublic

Authored by epriestley on Mar 25 2019, 9:34 PM.
Tags
None
Referenced Files
F15589786: D20323.id48506.diff
Fri, May 9, 3:10 PM
F15579553: D20323.id48509.diff
Wed, May 7, 12:50 AM
F15579552: D20323.id48506.diff
Wed, May 7, 12:50 AM
F15579551: D20323.id.diff
Wed, May 7, 12:50 AM
F15579550: D20323.diff
Wed, May 7, 12:50 AM
F15510078: D20323.id48506.diff
Wed, Apr 16, 6:36 PM
F15509508: D20323.id48509.diff
Wed, Apr 16, 1:01 PM
F15488552: D20323.id48509.diff
Thu, Apr 10, 11:27 PM
Subscribers
None

Details

Summary

Fixes T13270. In Diffusion, the "Code" tab is linked in a weird way that isn't consistent with the other tabs.

Particularly, if you navigate to x/y/z/ and toggle between the "Branches" and "History" tabs (or other tabs), you keep your path. If you click "Code", you lose your path.

Instead, retain the path, so you can navigate somewhere and then toggle to/from the "Code" tab to get different views of the same path.

Test Plan

Browed into a repository, clicked "History", clicked "Code", ended up back in the place I started.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable