Page MenuHomePhabricator

Provide a clearer UI for "view all results" in partial result panels
ClosedPublic

Authored by epriestley on Mar 22 2019, 10:32 PM.

Details

Summary

In some cases, we show a limited number of one type of object somewhere else, like "Recent Such-And-Such" or "Herald Rules Which Use This" or whatever.

We don't do a very good job of communicating that these are partial lists, or how to see all the results. Usually there's a button in the upper right, which is fine, but this could be better.

Add an explicit "more stuff" button that shows up where a pager would appear and makes it clear that (a) the list is partial; and (b) you can click the button to see everything.

Test Plan

Screen Shot 2019-03-22 at 3.27.44 PM.png (711×1 px, 127 KB)

Diff Detail

Repository
rP Phabricator
Branch
more1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22333
Build 30558: Run Core Tests
Build 30557: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Mar 22 2019, 10:32 PM
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
727

LOOK AT ME< I"M A FANCY DESIGNER

amckinley added inline comments.
webroot/rsrc/css/phui/object-item/phui-oi-list-view.css
727

IT'S BEAUTIFUL 😭

This revision is now accepted and ready to land.Mar 25 2019, 9:30 PM
This revision was automatically updated to reflect the committed changes.