If the user cancels a workboard drop flow, put things back where they were
ClosedPublic
Actions

Authored by epriestley on Mar 21 2019, 8:41 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13074: Plans: Workboard triggers, groups, and subproject columns

Commits

rP66c1d623c340: If the user cancels a workboard drop flow, put things back where they were

Summary

Ref T13074. If you hit a prompt on a drop operation (today: MFA; in the future, maybe "add a comment" or "assign this task"), we currently leave the board in a bad semi-frozen state if you cancel the workflow by pressing "Cancel" on the dialog.

Instead, put things back the way they were.

Test Plan

Dragged an MFA-required card, cancelled the MFA prompt, got a functional board instead of a semi-frozen board I needed to reload.

Diff Detail

Repository

rP Phabricator

Branch

trigger11

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22323
Build 30538: Run Core Tests
Build 30537: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 21 2019, 8:41 PM

Harbormaster completed remote builds in B22323: Diff 48459.Mar 21 2019, 8:42 PM

epriestley requested review of this revision.Mar 21 2019, 8:42 PM

epriestley mentioned this in T6415: Workboard drag and drop freezes indefinitely if it cannot access the server even temporarily.Mar 21 2019, 8:47 PM

amckinley accepted this revision.Mar 25 2019, 8:57 PM

amckinley added inline comments.

webroot/rsrc/js/application/projects/WorkboardBoard.js
517	Should this have a corresponding `lock()` somewhere?

This revision is now accepted and ready to land.Mar 25 2019, 8:57 PM

epriestley added inline comments.Mar 25 2019, 9:03 PM

webroot/rsrc/js/application/projects/WorkboardBoard.js
517	The paired `lock()` happens when you first pick up the card. We `unlock()` on success (below, in `_oncardupdate()`) already, this just adds an unlock when we complete the drag but have failed.