Page MenuHomePhabricator

When users hover over a column trigger menu, show a "preview" with the rules instead of a tooltip
ClosedPublic

Authored by epriestley on Mar 21 2019, 8:23 PM.
Tags
None
Referenced Files
F14117074: D20304.id48502.diff
Thu, Nov 28, 5:20 PM
Unknown Object (File)
Tue, Nov 26, 3:46 PM
Unknown Object (File)
Tue, Nov 26, 3:46 PM
Unknown Object (File)
Tue, Nov 26, 3:46 PM
Unknown Object (File)
Sat, Nov 23, 6:03 PM
Unknown Object (File)
Sat, Nov 23, 6:45 AM
Unknown Object (File)
Tue, Nov 12, 8:21 PM
Unknown Object (File)
Sun, Nov 3, 6:09 AM
Subscribers
None

Details

Summary

Ref T5474. The first rough cut of triggers showed some of the trigger rules in a tooltip when you hover over the "add/remove" trigger menu.

This isn't great since we don't have much room and it's a bit finnicky / hard to read.

Since we have a better way to show effects now in the drop preview, just use that instead. When you hover over the trigger menu, preview the trigger in the "drop effect" element, with a "Trigger: such-and-such" header.

Test Plan
  • This is pretty tough to screenshot.
  • Hovered over menu, got a sensible preview of the trigger effects.
  • Dragged a card over the menu, no preview.

Diff Detail

Repository
rP Phabricator
Branch
trigger10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22322
Build 30536: Run Core Tests
Build 30535: arc lint + arc unit