Page MenuHomePhabricator

Don't show workboard action previews if the action won't have any effect

Authored by epriestley on Mar 20 2019, 2:33 AM.
Referenced Files
F11786735: D20300.diff
Tue, May 30, 5:02 AM
Unknown Object (File)
Sat, May 20, 3:13 AM
Unknown Object (File)
Apr 28 2023, 1:39 AM
Unknown Object (File)
Apr 27 2023, 9:29 AM
Unknown Object (File)
Apr 11 2023, 8:12 AM
Unknown Object (File)
Apr 7 2023, 11:01 PM
Unknown Object (File)
Apr 2 2023, 10:42 AM
Unknown Object (File)
Apr 2 2023, 10:42 AM



Ref T10335. When you (for example) drag a "Resolved" task into a column with "Trigger: change status to resolved.", don't show a hint that the action will "Change status to resolved." since this isn't helpful and is somewhat confusing.

For now, the only visibility operator is "!=" since all current actions are simple field comparisons, but some actions in the future (like "add subscriber" or "remove project") might need other conditions.

Test Plan

Dragged cards in ways that previously provided useless hints: move from column A to column B on a "Group by Priority" board; drag a resolved task to a "Trigger: change status to as resolved" column. Saw a more accurate preview in both cases.

Drags which actually cause effects still show the effects correctly.

Diff Detail

rP Phabricator
Lint Not Applicable
Tests Not Applicable