Page MenuHomePhabricator

Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query
ClosedPublic

Authored by epriestley on Mar 18 2019, 10:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 21, 12:48 PM
Unknown Object (File)
Dec 24 2024, 2:56 AM
Unknown Object (File)
Dec 12 2024, 10:42 PM
Unknown Object (File)
Dec 12 2024, 10:42 PM
Unknown Object (File)
Dec 12 2024, 10:42 PM
Unknown Object (File)
Dec 12 2024, 10:42 PM
Unknown Object (File)
Dec 12 2024, 10:42 PM
Unknown Object (File)
Dec 9 2024, 12:10 AM
Subscribers
None

Details

Summary

Ref T13091. If you "Order By: Relevance" but don't actually specify a query, we currently raise a bare exception.

This operation is sort of silly/pointless, but it seems like it's probably best to just return the results for the other constraints in the fallback order (usually, by ID). Alternatively, we could raise a non-bare exception here ("You need to provide a fulltext query to order by relevance.")

Test Plan

Queried tasks by relevance with no actual query text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable