Page MenuHomePhabricator

Skip Ferret fulltext columns in "ORDER BY" if there's no fulltext query
ClosedPublic

Authored by epriestley on Mar 18 2019, 10:52 PM.
Tags
None
Referenced Files
F19024381: D20296.diff
Mon, Nov 24, 3:23 AM
F18985082: D20296.id48440.diff
Mon, Nov 17, 12:52 PM
F18971191: D20296.id48451.diff
Sat, Nov 15, 10:58 AM
F18769227: D20296.id48450.diff
Oct 8 2025, 6:53 AM
F18763349: D20296.id.diff
Oct 6 2025, 11:54 PM
F18733941: D20296.id.diff
Sep 30 2025, 10:44 PM
F18610548: D20296.diff
Sep 14 2025, 4:47 AM
F18597139: D20296.id48440.diff
Sep 13 2025, 2:12 AM
Subscribers
None

Details

Summary

Ref T13091. If you "Order By: Relevance" but don't actually specify a query, we currently raise a bare exception.

This operation is sort of silly/pointless, but it seems like it's probably best to just return the results for the other constraints in the fallback order (usually, by ID). Alternatively, we could raise a non-bare exception here ("You need to provide a fulltext query to order by relevance.")

Test Plan

Queried tasks by relevance with no actual query text.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable