Paths

Table of Contentst

Differential D20292

Convert simple query subclasses to use internal cursors
ClosedPublic
Actions

Authored by epriestley on Mar 18 2019, 7:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 19 2024, 5:12 PM

	Unknown Object (File)
	Dec 13 2024, 7:03 PM

	Unknown Object (File)
	Dec 12 2024, 10:42 PM

	Unknown Object (File)
	Dec 12 2024, 10:41 PM

	Unknown Object (File)
	Nov 26 2024, 3:44 PM

	Unknown Object (File)
	Nov 26 2024, 3:44 PM

	Unknown Object (File)
	Nov 11 2024, 1:57 AM

	Unknown Object (File)
	Nov 11 2024, 12:07 AM

Subscribers

Restricted Owners Package

Details

Reviewers

Maniphest Tasks

T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery"

Commits

rPd4847c3eeb78: Convert simple query subclasses to use internal cursors

Summary

Depends on D20291. Ref T13259. Move all the simple cases (where paging depends only on the partial object and does not depend on keys) to a simple wrapper.

This leaves a smaller set of more complex cases where we care about external data or which keys were requested that I'll convert in followups.

Test Plan

Poked at things, but a lot of stuff is still broken until everything is converted.

Diff Detail

Repository

Branch

cursor2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22298
Build 30496: Run Core Tests
Build 30495: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 18 2019, 7:01 PM

Owners added a subscriber: Restricted Owners Package.Mar 18 2019, 7:01 PM

Harbormaster completed remote builds in B22298: Diff 48433.Mar 18 2019, 7:03 PM

epriestley requested review of this revision.Mar 18 2019, 7:03 PM

epriestley added a child revision: D20293: Convert complex query subclasses to use internal cursors.Mar 18 2019, 9:04 PM

amckinley accepted this revision.Mar 18 2019, 10:01 PM

amckinley added inline comments.

src/applications/diviner/query/DivinerBookQuery.php
188	Wait, how did this ever work?

This revision is now accepted and ready to land.Mar 18 2019, 10:01 PM

epriestley added inline comments.Mar 18 2019, 10:04 PM

src/applications/diviner/query/DivinerBookQuery.php
188	It probably didn't. I think `/diviner/` shows all books and there's no normal `SearchEngine` API for books, so there's probably no way to query them with a limit, and thus no way to actually page through them. So it "worked" by being unreachable. Hopefully the new code is just as good!

epriestley mentioned this in T13266: Upgrading: Minor Changes to Query Paging / Cursors.Mar 19 2019, 6:51 PM

Closed by commit rPd4847c3eeb78: Convert simple query subclasses to use internal cursors (authored by epriestley). · Explain WhyMar 19 2019, 8:00 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".Mar 19 2019, 8:45 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

query/

AlmanacDeviceQuery.php

7 lines

AlmanacNamespaceQuery.php

7 lines

AlmanacServiceQuery.php

7 lines

badges/

query/

PhabricatorBadgesQuery.php

8 lines

calendar/

query/

PhabricatorCalendarEventQuery.php

7 lines

countdown/

query/

PhabricatorCountdownQuery.php

7 lines

differential/

query/

DifferentialRevisionQuery.php

7 lines

diffusion/

query/

DiffusionCommitQuery.php

7 lines

diviner/

query/

DivinerBookQuery.php

7 lines

harbormaster/

query/

HarbormasterBuildPlanQuery.php

7 lines

macro/

query/

PhabricatorMacroQuery.php

7 lines

owners/

query/

PhabricatorOwnersPackageQuery.php

7 lines

people/

query/

PhabricatorPeopleQuery.php

7 lines

phame/

query/

PhamePostQuery.php

12 lines

phlux/

query/

PhluxVariableQuery.php

4 lines

phrequent/

query/

PhrequentUserTimeQuery.php

9 lines

phurl/

query/

PhabricatorPhurlURLQuery.php

7 lines

project/

query/

PhabricatorProjectQuery.php

9 lines

releeph/

query/

ReleephProductQuery.php

8 lines

infrastructure/

query/

policy/

PhabricatorCursorPagedPolicyAwareQuery.php

4 lines

Diff 48433

src/applications/almanac/query/AlmanacDeviceQuery.php

Loading...

src/applications/almanac/query/AlmanacNamespaceQuery.php

Loading...

src/applications/almanac/query/AlmanacServiceQuery.php

Loading...

src/applications/badges/query/PhabricatorBadgesQuery.php

Loading...

src/applications/calendar/query/PhabricatorCalendarEventQuery.php

Loading...

src/applications/countdown/query/PhabricatorCountdownQuery.php

Loading...

src/applications/differential/query/DifferentialRevisionQuery.php

Loading...

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...

src/applications/diviner/query/DivinerBookQuery.php

Loading...

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

Loading...

src/applications/macro/query/PhabricatorMacroQuery.php

Loading...

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...

src/applications/phame/query/PhamePostQuery.php

Loading...

src/applications/phlux/query/PhluxVariableQuery.php

Loading...

src/applications/phrequent/query/PhrequentUserTimeQuery.php

Loading...

src/applications/phurl/query/PhabricatorPhurlURLQuery.php

Loading...

src/applications/project/query/PhabricatorProjectQuery.php

Loading...

src/applications/releeph/query/ReleephProductQuery.php

Loading...

src/infrastructure/query/policy/PhabricatorCursorPagedPolicyAwareQuery.php

Loading...