Page MenuHomePhabricator

Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers"
ClosedPublic

Authored by epriestley on Mar 14 2019, 1:53 PM.
Tags
None
Referenced Files
F12806964: D20285.diff
Wed, Mar 27, 6:51 PM
Unknown Object (File)
Sat, Mar 16, 4:55 AM
Unknown Object (File)
Thu, Mar 14, 2:03 PM
Unknown Object (File)
Feb 8 2024, 5:09 PM
Unknown Object (File)
Jan 20 2024, 12:25 AM
Unknown Object (File)
Jan 7 2024, 10:52 AM
Unknown Object (File)
Dec 30 2023, 2:45 AM
Unknown Object (File)
Dec 19 2023, 3:31 PM
Subscribers
None

Details

Summary

Fixes T13265. See that task for discussion. Briefly:

  • For mailers that use other mailers (SMTP, Sendmail), optionally let administrators set "message-id": false to improve threading behavior if their local Postfix is ultimately sending through SES or some other mailer which will replace the "Message-ID" header.

Also:

  • Postmark is currently marked as supporting "Message-ID", but it does not actually support "Message-ID" on secure.phabricator.com (mail arrives with a non-Phabricator message ID). I suspect this was just an oversight in building or refactoring the adapter; correct it.
  • Remove the "encoding" parameter from "sendmail". It think this was just missed in the cleanup a couple months ago; it is no longer used or documented.
Test Plan

Added and ran unit tests. (These feel like overkill, but this is super hard to test on real code.) See T13265 for evidence that this overall approach improves behavior.

Diff Detail

Repository
rP Phabricator
Branch
mail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22287
Build 30479: Run Core Tests
Build 30478: arc lint + arc unit

Event Timeline

  • Add SendGrid SMTP to the blocklist.
  • Simplify negative/default implementations of supportsMessageIDHeader().
amckinley added inline comments.
src/docs/user/configuration/configuring_outbound_email.diviner
467

Drop the rest of this sentence after "will be respected or not".

This revision is now accepted and ready to land.Mar 15 2019, 11:23 PM