Paths

Table of Contentst

Differential D20285

Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in "cluster.mailers"
ClosedPublic
Actions

Authored by epriestley on Mar 14 2019, 1:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 20, 11:29 PM

	Unknown Object (File)
	Sun, Nov 17, 5:36 AM

	Unknown Object (File)
	Wed, Oct 23, 9:57 PM

	Unknown Object (File)
	Oct 10 2024, 5:47 PM

	Unknown Object (File)
	Oct 10 2024, 5:47 PM

	Unknown Object (File)
	Oct 10 2024, 5:47 PM

	Unknown Object (File)
	Oct 10 2024, 5:47 PM

	Unknown Object (File)
	Oct 10 2024, 5:46 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T13265: Allow the SMTP mailer to be configured as a "Does Not Support Message-ID Header" mailer

Commits

rPb469a5134ddd: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in…

Summary

Fixes T13265. See that task for discussion. Briefly:

For mailers that use other mailers (SMTP, Sendmail), optionally let administrators set "message-id": false to improve threading behavior if their local Postfix is ultimately sending through SES or some other mailer which will replace the "Message-ID" header.

Also:

Postmark is currently marked as supporting "Message-ID", but it does not actually support "Message-ID" on secure.phabricator.com (mail arrives with a non-Phabricator message ID). I suspect this was just an oversight in building or refactoring the adapter; correct it.
Remove the "encoding" parameter from "sendmail". It think this was just missed in the cleanup a couple months ago; it is no longer used or documented.

Test Plan

Added and ran unit tests. (These feel like overkill, but this is super hard to test on real code.) See T13265 for evidence that this overall approach improves behavior.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 14 2019, 1:53 PM

Harbormaster completed remote builds in B22285: Diff 48422.Mar 14 2019, 1:54 PM

epriestley requested review of this revision.Mar 14 2019, 1:54 PM

Fix "the the" typo.

Harbormaster completed remote builds in B22286: Diff 48423.Mar 14 2019, 2:02 PM

Add SendGrid SMTP to the blocklist.
Simplify negative/default implementations of supportsMessageIDHeader().

Harbormaster completed remote builds in B22287: Diff 48424.Mar 14 2019, 3:15 PM

amckinley accepted this revision.Mar 15 2019, 11:23 PM

amckinley added inline comments.

src/docs/user/configuration/configuring_outbound_email.diviner
467	Drop the rest of this sentence after "will be respected or not".

This revision is now accepted and ready to land.Mar 15 2019, 11:23 PM

Closed by commit rPb469a5134ddd: Allow "SMTP" and "Sendmail" mailers to have "Message-ID" behavior configured in… (authored by epriestley). · Explain WhyMar 16 2019, 7:36 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

metamta/

adapter/

PhabricatorMailAdapter.php

33 lines

PhabricatorMailAmazonSESAdapter.php

4 lines

PhabricatorMailPostmarkAdapter.php

4 lines

PhabricatorMailSMTPAdapter.php

6 lines

PhabricatorMailSendmailAdapter.php

9 lines

__tests__/

PhabricatorMailAdapterTestCase.php

96 lines

docs/

user/

configuration/

configuring_outbound_email.diviner

57 lines

Diff 48431

src/__phutil_library_map__.php

Loading...

src/applications/metamta/adapter/PhabricatorMailAdapter.php

Loading...

src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php

Loading...

src/applications/metamta/adapter/PhabricatorMailPostmarkAdapter.php

Loading...

src/applications/metamta/adapter/PhabricatorMailSMTPAdapter.php

Loading...

src/applications/metamta/adapter/PhabricatorMailSendmailAdapter.php

Loading...

src/applications/metamta/adapter/tests/PhabricatorMailAdapterTestCase.php

Loading...

src/docs/user/configuration/configuring_outbound_email.diviner

Loading...