Page MenuHomePhabricator

Don't subscribe bots implicitly when they act on objects, or when they are mentioned
ClosedPublic

Authored by epriestley on Mar 13 2019, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 10:06 AM
Unknown Object (File)
Jan 30 2024, 11:24 PM
Unknown Object (File)
Jan 22 2024, 3:37 AM
Unknown Object (File)
Dec 19 2023, 11:18 PM
Unknown Object (File)
Nov 30 2023, 5:45 AM
Unknown Object (File)
Nov 19 2023, 12:08 AM
Unknown Object (File)
Nov 17 2023, 12:53 AM
Unknown Object (File)
Oct 30 2023, 8:13 AM
Subscribers
None

Details

Summary

See PHI1098. When users comment on objects, they are automatically subscribed. And when @alice mentions @bailey on a task, that usually subscribes @bailey.

These rules make less sense if the user is a bot. There's generally no reason for a bot to automatically subscribe to objects it acts on (it's not going to read email and follow up later), and it can always subscribe itself pretty easily if it wants (since everything is *.edit now and supports subscribe transactions).

Also, don't subscribe bots when they're mentioned for similar reasons. If users really want to subscribe bots, they can do so explicitly.

These rules seem slightly like "bad implicit magic" since it's not immediately obvious why @abc subscribes that user but @xyz may not, but some of these rules are fairly complicated already (e.g., @xyz doesn't subscribe them if they unsubscribed or are implicitly subscribed) and this feels like it gets the right/desired result almost-always.

Test Plan

On a fresh task:

  • Mentioned a bot in a comment with @bot.
    • Before patch: bot got CC'd.
    • After patch: no CC.
  • Called maniphest.edit via the API to add a comment as a bot.
    • Before patch: bot got CC'd.
    • After patch: no CC.

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22282
Build 30471: Run Core Tests
Build 30470: arc lint + arc unit