Paths

Table of Contentst

Differential D20257

Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked
ClosedPublic
Actions

Authored by epriestley on Mar 7 2019, 4:52 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13249: 2019 Week 7 - 10 Bonus Content

Commits

rP77221bee72cb: Allow objects to specify custom policy unlocking behavior, and tasks to have…

Summary

Depends on D20256. Ref T13249. See PHI1115. This primarily makes bin/policy unlock --owner epriestley T123 work. This is important for "Edit Locked" tasks, since changing the edit policy doesn't really do anything.

Test Plan

Hard-locked a task as "alice", reassigned it to myself with bin/policy unlock --owner epriestley.

Diff Detail

Repository

rP Phabricator

Branch

unlock2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22208
Build 30361: Run Core Tests
Build 30360: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2019, 4:52 AM

Harbormaster completed remote builds in B22208: Diff 48349.Mar 7 2019, 4:54 AM

epriestley requested review of this revision.Mar 7 2019, 4:54 AM

amckinley accepted this revision.Mar 7 2019, 8:15 PM

amckinley mentioned this in D20256: Update "bin/policy unlock" to be more surgical, flexible, modular, and modern.

This revision is now accepted and ready to land.Mar 7 2019, 8:16 PM

Closed by commit rP77221bee72cb: Allow objects to specify custom policy unlocking behavior, and tasks to have… (authored by epriestley). · Explain WhyMar 7 2019, 8:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

maniphest/

engine/

ManiphestTaskUnlockEngine.php

14 lines

storage/

ManiphestTask.php

11 lines

system/

engine/

PhabricatorUnlockEngine.php

8 lines

interface/

PhabricatorUnlockableInterface.php

18 lines

Diff 48349

View Options

src/__phutil_library_map__.php

View Options

src/applications/maniphest/engine/ManiphestTaskUnlockEngine.php

View Options

src/applications/maniphest/storage/ManiphestTask.php

View Options

src/applications/system/engine/PhabricatorUnlockEngine.php

View Options

src/applications/system/interface/PhabricatorUnlockableInterface.php

Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlockedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 48349

src/__phutil_library_map__.php

src/applications/maniphest/engine/ManiphestTaskUnlockEngine.php

src/applications/maniphest/storage/ManiphestTask.php

src/applications/system/engine/PhabricatorUnlockEngine.php

src/applications/system/interface/PhabricatorUnlockableInterface.php

Allow objects to specify custom policy unlocking behavior, and tasks to have owners unlocked
ClosedPublic
Actions

Revision Contents
Changeset List