Differential D20238

Make it more visually clear that you can click things in the "Big List of Clickable Things" UI element
ClosedPublic
Actions

Authored by epriestley on Mar 1 2019, 3:16 PM.

Details

Reviewers

Maniphest Tasks

T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery"

Commits

rPd192d04586ec: Make it more visually clear that you can click things in the "Big List of…

Summary

Ref T13259. An install provided feedback that it wasn't obvious you could click the buttons in this UI.

Make it more clear that these are clickable buttons.

Test Plan

Screen Shot 2019-03-01 at 7.12.59 AM.png (1×1 px, 331 KB)

Screen Shot 2019-03-01 at 7.15.16 AM.png (297×597 px, 20 KB)

Diff Detail

Repository

rP Phabricator

Branch

ui1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22166
Build 30295: Run Core Tests
Build 30294: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 1 2019, 3:16 PM

Harbormaster completed remote builds in B22166: Diff 48305.Mar 1 2019, 3:17 PM

epriestley requested review of this revision.Mar 1 2019, 3:17 PM

amckinley accepted this revision.Mar 5 2019, 6:18 PM

This revision is now accepted and ready to land.Mar 5 2019, 6:18 PM

Closed by commit rPd192d04586ec: Make it more visually clear that you can click things in the "Big List of… (authored by epriestley). · Explain WhyMar 5 2019, 7:32 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".Mar 19 2019, 8:45 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

css/

phui/

object-item/

phui-oi-big-ui.css

26 lines

Diff 48305

View Options

resources/celerity/map.php