Page MenuHomePhabricator

Correct various minor diff copy behaviors
ClosedPublic

Authored by epriestley on Feb 17 2019, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 10:21 PM
Unknown Object (File)
Feb 9 2024, 11:17 PM
Unknown Object (File)
Feb 3 2024, 9:26 PM
Unknown Object (File)
Dec 27 2023, 2:04 PM
Unknown Object (File)
Dec 22 2023, 1:40 AM
Unknown Object (File)
Dec 17 2023, 10:00 PM
Unknown Object (File)
Dec 17 2023, 6:45 AM
Unknown Object (File)
Dec 13 2023, 4:27 AM
Subscribers
None

Details

Summary

Ref T12822. Fixes a few things:

  • Firefox selection of weird ranges with an inline between the start and end of the range now works correctly.
  • "Show More Context" rows now render, highlight, and select properly.
  • Prepares for nodes to have copy-text which is different from display-text.
  • Don't do anything too fancy in 1-up/unified mode. We don't copy line numbers after the content: attr(data-n) change, but that's as far as we go, because trying to do more than that is kind of weird and not terribly intuitive.
Test Plan
  • Selected and copied weird ranges in Firefox.
  • Kept an eye on "Show More Context" rows across select and copy operations.
  • Generally poked around in Safari/Firefox/Chrome.

Diff Detail

Repository
rP Phabricator
Branch
sorcery5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22048
Build 30122: Run Core Tests
Build 30121: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 19 2019, 10:50 PM
This revision was automatically updated to reflect the committed changes.