Paths

Table of Contentst

Differential D20184

Clean up a couple more URI alter() calls
ClosedPublic
Actions

Authored by epriestley on Feb 15 2019, 9:58 PM.

Tags

None

Referenced Files

	F15544570: D20184.id48180.diff
	Sat, Apr 26, 5:55 AM

	F15528767: D20184.id48180.diff
	Tue, Apr 22, 1:51 PM

	F15491282: D20184.diff
	Sat, Apr 12, 1:15 AM

	F15489411: D20184.id48179.diff
	Fri, Apr 11, 8:52 AM

	F15488903: D20184.id48180.diff
	Fri, Apr 11, 4:09 AM

	F15488130: D20184.id.diff
	Thu, Apr 10, 7:45 PM

	F15485162: D20184.diff
	Wed, Apr 9, 10:13 PM

	F15416454: D20184.diff
	Mar 20 2025, 11:11 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb09cf166a8bd: Clean up a couple more URI alter() calls

Summary

See https://discourse.phabricator-community.org/t/create-new-phriction-document-fails-with-unhandled-exception-invalidargumentexception/2406.

These weren't obviously nullable from a cursory grep, but are sometimes nullable in practice.

Test Plan

Created, then saved a new Phriction document.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 15 2019, 9:58 PM

Harbormaster completed remote builds in B22024: Diff 48179.Feb 15 2019, 10:00 PM

epriestley requested review of this revision.Feb 15 2019, 10:00 PM

amckinley accepted this revision.Feb 15 2019, 10:01 PM

This revision is now accepted and ready to land.Feb 15 2019, 10:01 PM

Closed by commit rPb09cf166a8bd: Clean up a couple more URI alter() calls (authored by epriestley). · Explain WhyFeb 15 2019, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

11 lines

view/

phui/

PHUITimelineView.php

17 lines

Diff 48180

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php