Paths

Table of Contentst

Differential D20184

Clean up a couple more URI alter() calls
ClosedPublic
Actions

Authored by epriestley on Feb 15 2019, 9:58 PM.

Tags

None

Referenced Files

	F18112794: D20184.id.diff
	Tue, Aug 12, 8:49 PM

	F18110882: D20184.diff
	Tue, Aug 12, 1:29 AM

	F17711993: D20184.diff
	Jul 17 2025, 9:21 AM

	Unknown Object (File)
	Jun 15 2025, 3:52 AM

	Unknown Object (File)
	Jun 2 2025, 2:44 PM

	Unknown Object (File)
	Jun 1 2025, 8:51 AM

	Unknown Object (File)
	May 29 2025, 4:20 AM

	Unknown Object (File)
	May 28 2025, 8:05 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPb09cf166a8bd: Clean up a couple more URI alter() calls

Summary

See https://discourse.phabricator-community.org/t/create-new-phriction-document-fails-with-unhandled-exception-invalidargumentexception/2406.

These weren't obviously nullable from a cursory grep, but are sometimes nullable in practice.

Test Plan

Created, then saved a new Phriction document.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 15 2019, 9:58 PM

Harbormaster completed remote builds in B22024: Diff 48179.Feb 15 2019, 10:00 PM

epriestley requested review of this revision.Feb 15 2019, 10:00 PM

amckinley accepted this revision.Feb 15 2019, 10:01 PM

This revision is now accepted and ready to land.Feb 15 2019, 10:01 PM

Closed by commit rPb09cf166a8bd: Clean up a couple more URI alter() calls (authored by epriestley). · Explain WhyFeb 15 2019, 10:07 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phriction/

editor/

PhrictionTransactionEditor.php

11 lines

view/

phui/

PHUITimelineView.php

17 lines

Diff 48180

View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php