Page MenuHomePhabricator
Differential D20176

Fix a URI construction in remarkup macro/meme rules
ClosedPublic
Actions

Authored by epriestley on Feb 15 2019, 12:56 PM.
Tags
None
Referenced Files
F14002623: D20176.diff
Fri, Oct 25, 8:44 PM
F13962821: D20176.id48181.diff
Tue, Oct 15, 12:31 PM
Unknown Object (File)
Oct 9 2024, 11:43 AM
Unknown Object (File)
Sep 27 2024, 2:30 AM
Unknown Object (File)
Sep 23 2024, 12:25 PM
Unknown Object (File)
Sep 21 2024, 12:04 AM
Unknown Object (File)
Sep 20 2024, 12:03 AM
Unknown Object (File)
Sep 6 2024, 5:38 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
Commits
rP66060b294bce: Fix a URI construction in remarkup macro/meme rules
Summary

Ref T13250. Some of these parameters may be NULL, and alter() is no longer happy about that.

Test Plan

Ran daemon tasks that happened to render some memes.

Diff Detail

Repository
rP Phabricator
Branch
meme1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 22016
Build 30074: Run Core Tests
Build 30073: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
macro/
engine/
11 lines

Diff 48171

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php

Loading...
Phabricator · Built by Phacility