Paths

Table of Contentst

Differential D20176

Fix a URI construction in remarkup macro/meme rules
ClosedPublic
Actions

Authored by epriestley on Feb 15 2019, 12:56 PM.

Tags

None

Referenced Files

	F18628051: D20176.id48171.diff
	Tue, Sep 16, 5:27 AM

	F18100312: D20176.diff
	Aug 9 2025, 11:49 AM

	F18049122: D20176.id48171.diff
	Aug 3 2025, 3:29 PM

	F17999386: D20176.id.diff
	Aug 2 2025, 6:27 AM

	F17958741: D20176.diff
	Aug 1 2025, 7:18 AM

	Unknown Object (File)
	Jun 27 2025, 11:06 AM

	Unknown Object (File)
	Jun 27 2025, 6:01 AM

	Unknown Object (File)
	Jun 19 2025, 4:24 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rP66060b294bce: Fix a URI construction in remarkup macro/meme rules

Summary

Ref T13250. Some of these parameters may be NULL, and alter() is no longer happy about that.

Test Plan

Ran daemon tasks that happened to render some memes.

Diff Detail

Repository

rP Phabricator

Branch

meme1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 22016
Build 30074: Run Core Tests
Build 30073: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2019, 12:56 PM

Harbormaster completed remote builds in B22016: Diff 48171.Feb 15 2019, 12:58 PM

epriestley requested review of this revision.Feb 15 2019, 12:58 PM

amckinley accepted this revision.Feb 15 2019, 4:37 PM

This revision is now accepted and ready to land.Feb 15 2019, 4:37 PM

Closed by commit rP66060b294bce: Fix a URI construction in remarkup macro/meme rules (authored by epriestley). · Explain WhyFeb 15 2019, 10:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

engine/

PhabricatorMemeEngine.php

11 lines

Diff 48171

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php

Fix a URI construction in remarkup macro/meme rulesClosedPublicActions