Add a standalone view for the Maniphest task graph
ClosedPublic
Actions

Authored by epriestley on Feb 14 2019, 1:55 AM.

Details

Reviewers

amckinley

Commits

rP8810cd2f4d15: Add a standalone view for the Maniphest task graph

Summary

See PHI1073. Improve the UX here:

When there are a small number of connected tasks, no changes.
When there are too many total connected tasks, but not too many directly connected tasks, show hint text with a "View Standalone Graph" button to view more of the graph.
When there are too many directly connected tasks, show better hint text with a "View Standalone Graph" button.
Always show a "View Standalone Graph" option in the dropdown menu.
Add a standalone view which works the same way but has a limit of 2,000.
- This view doesn't have "View Standalone Graph" links, since they'd just link back to the same page, but is basically the same otherwise.
Increase the main page task limit from 100 to 200.

Test Plan

Mobile View:

Screen Shot 2019-02-13 at 5.48.55 PM.png (205×485 px, 26 KB)

Way too much stuff:

New persistent link to the standalone page:

Screen Shot 2019-02-13 at 5.49.09 PM.png (188×287 px, 15 KB)

Kind of too much stuff:

Screen Shot 2019-02-13 at 5.49.47 PM.png (901×1 px, 135 KB)

Standalone view:

Screen Shot 2019-02-13 at 5.49.58 PM.png (1×1 px, 322 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 14 2019, 1:55 AM

Harbormaster completed remote builds in B21992: Diff 48148.Feb 14 2019, 1:56 AM

epriestley requested review of this revision.Feb 14 2019, 1:56 AM

The pathological case here is that you have a single unbroken chain of exactly 2,000 tasks where each has exactly one child, T1 -> T2 -> T3 -> ... -> T2000, and you view either T1 or T2000. In this case, we make 2,000 queries: we walk up or down one level of the graph with each query.

No one does this and 2,000 queries will probably take less than 30 seconds, and even if they don't this doesn't fatal the main page, so this generally feels like it's not likely to cause any major issues.