Bump the markup cache version for URI changes
ClosedPublic
Actions

Authored by epriestley on Feb 13 2019, 4:59 PM.

Details

Reviewers

Maniphest Tasks

T13249: 2019 Week 7 - 10 Bonus Content
T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rPf77942a2d11b: (stable) Bump the markup cache version for URI changes
rP991368128e4d: Bump the markup cache version for URI changes

Summary

Ref T13250. Ref T13249. Some remarkup rules, including {image ...} and {meme ...}, may cache URIs as objects because the remarkup cache is serialize()-based.

URI objects with query cached as a key-value map are no longer valid and can raise __toString() fatals.

Bump the cache version to purge them out of the cache.

Test Plan

See PHI1074.

Diff Detail

Repository

rP Phabricator

Branch

cache1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21983
Build 30025: Run Core Tests
Build 30024: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2019, 4:59 PM

Harbormaster completed remote builds in B21983: Diff 48139.Feb 13 2019, 5:01 PM

epriestley requested review of this revision.Feb 13 2019, 5:01 PM

amckinley accepted this revision.Feb 13 2019, 6:38 PM

This revision is now accepted and ready to land.Feb 13 2019, 6:38 PM

Closed by commit rP991368128e4d: Bump the markup cache version for URI changes (authored by epriestley). · Explain WhyFeb 13 2019, 8:25 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

2 lines

Diff 48139

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Bump the markup cache version for URI changesClosedPublicActions