Page MenuHomePhabricator

Don't try to publish build results to bare diffs
ClosedPublic

Authored by epriestley on Feb 12 2019, 11:29 PM.
Tags
None
Referenced Files
F14411953: D20156.diff
Tue, Dec 24, 12:25 PM
Unknown Object (File)
Fri, Dec 13, 8:42 AM
Unknown Object (File)
Fri, Dec 13, 12:35 AM
Unknown Object (File)
Tue, Nov 26, 7:43 PM
Unknown Object (File)
Nov 22 2024, 12:04 AM
Unknown Object (File)
Nov 18 2024, 6:31 AM
Unknown Object (File)
Nov 14 2024, 5:53 AM
Unknown Object (File)
Nov 9 2024, 5:51 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/conduit-call-is-generating-phd-log-error-message/2380/. If you run builds against a diff which is not attached to a revision (this is unusual) we still try to publish to the associated revision. This won't work since there is no associated revision.

Since bare diffs don't really have a timeline, just publish nowhere for now.

Test Plan
  • Created a diff.
  • Did not attach it to a revision.
  • Created a build plan with "make http request + wait for response".
  • Manually ran the build plan against the bare diff.
  • Used bin/phd debug task to run the build and hit a "revision not attached" exception during publishing.
  • Applied patch.
  • Ran bin/phd debug task, got clean (no-op) publish.
  • Sent build a failure message with "harbormaster.sendmessage", got a failed build.

This isn't a real workflow, but shouldn't fail.

Diff Detail

Repository
rP Phabricator
Branch
harbor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21977
Build 30014: Run Core Tests
Build 30013: arc lint + arc unit