Page MenuHomePhabricator

Don't try to publish build results to bare diffs
ClosedPublic

Authored by epriestley on Feb 12 2019, 11:29 PM.
Tags
None
Referenced Files
F19807836: D20156.id48142.diff
Mar 3 2026, 5:26 AM
F19802352: D20156.id48133.diff
Mar 1 2026, 4:08 PM
F19792233: D20156.id.diff
Feb 26 2026, 9:48 AM
F19783639: D20156.diff
Feb 24 2026, 5:00 PM
F19100276: D20156.id.diff
Dec 4 2025, 11:01 PM
F19078697: D20156.diff
Dec 1 2025, 6:57 PM
F18867326: D20156.id.diff
Nov 3 2025, 11:14 PM
F18851657: D20156.diff
Oct 31 2025, 2:50 AM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/conduit-call-is-generating-phd-log-error-message/2380/. If you run builds against a diff which is not attached to a revision (this is unusual) we still try to publish to the associated revision. This won't work since there is no associated revision.

Since bare diffs don't really have a timeline, just publish nowhere for now.

Test Plan
  • Created a diff.
  • Did not attach it to a revision.
  • Created a build plan with "make http request + wait for response".
  • Manually ran the build plan against the bare diff.
  • Used bin/phd debug task to run the build and hit a "revision not attached" exception during publishing.
  • Applied patch.
  • Ran bin/phd debug task, got clean (no-op) publish.
  • Sent build a failure message with "harbormaster.sendmessage", got a failed build.

This isn't a real workflow, but shouldn't fail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable