Details
Details
- Reviewers
amckinley - Maniphest Tasks
- T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules
- Commits
- rP9e0a954324e5: (stable) Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1"…
rP308c4f240754: Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1" parameters in…
Visited /search/hovercard/?phids[]=X, no more fatal. Dumped the resulting URI, saw it had the right value. Tried ?phids[]=x&x=1&x=1&x=1, saw the parameters correctly preserved.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- hover1
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21950 Build 29972: Run Core Tests Build 29971: arc lint + arc unit
Event Timeline
Comment Actions
There's some small possibility that $_GET and REQUEST_URI do not agree in some environments and that this will create even more problems. However, they agree locally, and we already use REQUEST_URI in some other cases without issues, and I couldn't find any internet evidence that REQUEST_URI is suspect.
We do have some code to turn a bag of PHP-flavored parameters into a query string (AphrontRequest::flattenData()) so we could just flatten $_GET, but that code is pretty icky so I'm hoping we can get away without increasing our reliance on it.