Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1" parameters in the URI
ClosedPublic
Actions

Authored by epriestley on Feb 12 2019, 1:42 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13250: Some typeaheads use nonscalar HTTP parameters, which fatal under new "phutil_build_http_query()" rules

Commits

rP9e0a954324e5: (stable) Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1"…
rP308c4f240754: Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1" parameters in…

Summary

Ref T13250. See PHI1069. This is a small fix for getRequestURI() currently not working if the request includes "x[]=..." PHP-flavored array parameters, beacause they're parsed into arrays by $_GET and setQueryParams(...) no longer accepts nonscalars.

Instead, just parse the raw request URI.

Test Plan

Visited /search/hovercard/?phids[]=X, no more fatal. Dumped the resulting URI, saw it had the right value. Tried ?phids[]=x&x=1&x=1&x=1, saw the parameters correctly preserved.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 12 2019, 1:42 PM

Harbormaster completed remote builds in B21950: Diff 48107.Feb 12 2019, 1:43 PM

epriestley requested review of this revision.Feb 12 2019, 1:43 PM

amckinley accepted this revision.Feb 12 2019, 6:49 PM

This revision is now accepted and ready to land.Feb 12 2019, 6:49 PM

There's some small possibility that $_GET and REQUEST_URI do not agree in some environments and that this will create even more problems. However, they agree locally, and we already use REQUEST_URI in some other cases without issues, and I couldn't find any internet evidence that REQUEST_URI is suspect.

We do have some code to turn a bag of PHP-flavored parameters into a query string (AphrontRequest::flattenData()) so we could just flatten $_GET, but that code is pretty icky so I'm hoping we can get away without increasing our reliance on it.

Closed by commit rP308c4f240754: Fix "AphrontRequest->getRequestURI()" for requests with "x[]=1" parameters in… (authored by epriestley). · Explain WhyFeb 12 2019, 7:03 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13260: Google auth fails and throws exception about missing client state parameter.Feb 28 2019, 1:41 PM