Differential D20075

Allow parent and child revisions to be modified via Conduit
ClosedPublic
Actions

Authored by epriestley on Jan 31 2019, 4:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 2:14 AM

	Unknown Object (File)
	Fri, Dec 20, 8:51 PM

	Unknown Object (File)
	Fri, Dec 20, 2:54 PM

	Unknown Object (File)
	Sat, Dec 14, 5:27 AM

	Unknown Object (File)
	Fri, Dec 13, 3:18 AM

	Unknown Object (File)
	Dec 6 2024, 5:03 AM

	Unknown Object (File)
	Dec 4 2024, 3:29 PM

	Unknown Object (File)
	Nov 28 2024, 7:34 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPbc61d09f5553: Allow parent and child revisions to be modified via Conduit

Summary

See PHI1048. We have similar transactions elsewhere already (particularly, on tasks) and these edges don't have any special properties (like "Closes Txx As Wontfix" edges do) so this doesn't create any sort of peril.

Test Plan

Diff Detail

Repository

rP Phabricator

Branch

parents1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21786
Build 29729: Run Core Tests
Build 29728: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 31 2019, 4:25 PM

Harbormaster completed remote builds in B21786: Diff 47935.Jan 31 2019, 4:26 PM

epriestley requested review of this revision.Jan 31 2019, 4:26 PM

amckinley accepted this revision.Feb 1 2019, 4:06 AM

This revision is now accepted and ready to land.Feb 1 2019, 4:06 AM

Closed by commit rPbc61d09f5553: Allow parent and child revisions to be modified via Conduit (authored by epriestley). · Explain WhyFeb 1 2019, 6:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

26 lines

Diff 47935

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Allow parent and child revisions to be modified via ConduitClosedPublicActions