Page MenuHomePhabricator

Read POST data sightly earlier in request startup
ClosedPublic

Authored by epriestley on Jan 31 2019, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 27, 10:08 PM
Unknown Object (File)
Wed, Mar 27, 5:12 PM
Unknown Object (File)
Wed, Mar 27, 5:12 PM
Unknown Object (File)
Wed, Mar 27, 5:11 PM
Unknown Object (File)
Wed, Mar 27, 5:11 PM
Unknown Object (File)
Sat, Mar 23, 12:36 PM
Unknown Object (File)
Sat, Mar 23, 12:36 PM
Unknown Object (File)
Sat, Mar 23, 12:36 PM
Subscribers
None

Details

Summary

On instances, the "SiteSource" (for site config) pretty much copy-pastes the "read POST data" block because it needs to make some decisions based on POST data when handling inbound mail webhooks.

Move the upstream read a little earlier so we can get rid of this. Now that this step is separated and must happen before the profiler, there's no reason not to do it earlier.

Test Plan

POSTed some data across pages without issue, will remove duplicate code in upcoming change.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable