Page MenuHomePhabricator

Read POST data sightly earlier in request startup
ClosedPublic

Authored by epriestley on Thu, Jan 31, 3:33 PM.

Details

Summary

On instances, the "SiteSource" (for site config) pretty much copy-pastes the "read POST data" block because it needs to make some decisions based on POST data when handling inbound mail webhooks.

Move the upstream read a little earlier so we can get rid of this. Now that this step is separated and must happen before the profiler, there's no reason not to do it earlier.

Test Plan

POSTed some data across pages without issue, will remove duplicate code in upcoming change.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Thu, Jan 31, 3:33 PM
epriestley requested review of this revision.Thu, Jan 31, 3:35 PM
epriestley edited the summary of this revision. (Show Details)Thu, Jan 31, 3:39 PM
amckinley accepted this revision.Fri, Feb 1, 4:01 AM
This revision is now accepted and ready to land.Fri, Feb 1, 4:01 AM
This revision was automatically updated to reflect the committed changes.