Differential D20072

Update a factor query in TransactionEditor for providers
ClosedPublic
Actions

Authored by epriestley on Jan 30 2019, 11:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 12, 6:08 PM

	Unknown Object (File)
	Thu, Apr 11, 9:30 AM

	Unknown Object (File)
	Mon, Apr 8, 8:57 PM

	Unknown Object (File)
	Sun, Apr 7, 12:15 AM

	Unknown Object (File)
	Fri, Mar 29, 6:15 AM

	Unknown Object (File)
	Wed, Mar 27, 5:23 PM

	Unknown Object (File)
	Wed, Mar 27, 5:23 PM

	Unknown Object (File)
	Wed, Mar 27, 5:11 PM

View All 78 Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP93b512b63cca: Update a factor query in TransactionEditor for providers

Summary

This query didn't get updated and could let you through an explicit "Sign with MFA" action if you have only disabled factors on your account.

Test Plan

Disabled all factors.
Used explicit "Sign With MFA".
- Before: Went through.
- After: Sensible error.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 30 2019, 11:05 PM

Harbormaster completed remote builds in B21772: Diff 47922.Jan 30 2019, 11:06 PM

epriestley requested review of this revision.Jan 30 2019, 11:06 PM

amckinley accepted this revision.Jan 31 2019, 2:45 AM

This revision is now accepted and ready to land.Jan 31 2019, 2:45 AM

Closed by commit rP93b512b63cca: Update a factor query in TransactionEditor for providers (authored by epriestley). · Explain WhyJan 31 2019, 3:27 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

12 lines

Diff 47927

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Update a factor query in TransactionEditor for providersClosedPublicActions