Page MenuHomePhabricator

Hide "Signed with MFA" stories from feed
ClosedPublic

Authored by epriestley on Jan 30 2019, 11:01 PM.
Tags
None
Referenced Files
F19941733: D20071.id47921.diff
Wed, Apr 15, 12:52 PM
F19941732: D20071.id47921.diff
Wed, Apr 15, 12:52 PM
F19902833: D20071.id.diff
Mon, Mar 30, 9:26 PM
F19868205: D20071.id.diff
Mar 15 2026, 1:39 AM
F19819363: D20071.id.diff
Mar 6 2026, 5:43 AM
F19819362: D20071.id.diff
Mar 6 2026, 5:43 AM
F19788609: D20071.diff
Feb 25 2026, 4:16 PM
F19788606: D20071.diff
Feb 25 2026, 4:12 PM
Subscribers
None

Details

Summary

See https://discourse.phabricator-community.org/t/sign-with-mfa-action-on-differential-revisions-creates-strange-feed-entries/2346.

If you "Sign with MFA" and only add a comment, we can produce a weird notification and feed story. Hide these stories from feed since they're broadly not interesting.

Test Plan
  • Used "sign with MFA" and only posted a comment.
  • Observed feed.
    • Before: Janky "untitled story".
    • After: Sensible "added a comment" story.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jan 31 2019, 2:46 AM
This revision was automatically updated to reflect the committed changes.