Page MenuHomePhabricator

Hide "Signed with MFA" stories from feed
ClosedPublic

Authored by epriestley on Jan 30 2019, 11:01 PM.

Details

Summary

See https://discourse.phabricator-community.org/t/sign-with-mfa-action-on-differential-revisions-creates-strange-feed-entries/2346.

If you "Sign with MFA" and only add a comment, we can produce a weird notification and feed story. Hide these stories from feed since they're broadly not interesting.

Test Plan
  • Used "sign with MFA" and only posted a comment.
  • Observed feed.
    • Before: Janky "untitled story".
    • After: Sensible "added a comment" story.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Jan 30 2019, 11:01 PM
epriestley requested review of this revision.Jan 30 2019, 11:03 PM
amckinley accepted this revision.Jan 31 2019, 2:46 AM
This revision is now accepted and ready to land.Jan 31 2019, 2:46 AM
This revision was automatically updated to reflect the committed changes.