Differential D20059

Give MFA gates a more consistent UI
ClosedPublic
Actions

Authored by epriestley on Jan 29 2019, 10:43 PM.

Tags

None

Referenced Files

	F14892289: D20059.id47903.diff
	Sun, Feb 9, 7:03 AM

	F14892288: D20059.id47894.diff
	Sun, Feb 9, 7:03 AM

	F14892287: D20059.id.diff
	Sun, Feb 9, 7:03 AM

	F14892286: D20059.diff
	Sun, Feb 9, 7:03 AM

	F14892149: D20059.diff
	Sun, Feb 9, 6:58 AM

	Unknown Object (File)
	Sun, Feb 2, 11:32 AM

	Unknown Object (File)
	Wed, Jan 29, 1:26 AM

	Unknown Object (File)
	Sat, Jan 25, 3:25 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP13e4aeb59059: Give MFA gates a more consistent UI

Summary

Depends on D20057. Currently, we show an "MFA" message on one of these and an "Error" message on the other, with different icons and colors. Use "MFA" for both, with the MFA icon / color.

Test Plan

Hit both varations, saw more consistency.

Diff Detail

Repository

rP Phabricator

Branch

xmail2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21750
Build 29682: Run Core Tests
Build 29681: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2019, 10:43 PM

Harbormaster completed remote builds in B21750: Diff 47894.Jan 29 2019, 10:45 PM

epriestley requested review of this revision.Jan 29 2019, 10:45 PM

amckinley accepted this revision.Jan 30 2019, 6:39 AM

This revision is now accepted and ready to land.Jan 30 2019, 6:39 AM

Closed by commit rP13e4aeb59059: Give MFA gates a more consistent UI (authored by epriestley). · Explain WhyJan 30 2019, 2:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

aphront/

handler/

PhabricatorHighSecurityRequestExceptionHandler.php

22 lines

Diff 47894

View Options

src/aphront/handler/PhabricatorHighSecurityRequestExceptionHandler.php

Give MFA gates a more consistent UIClosedPublicActions