Page MenuHomePhabricator
Differential D20059

Give MFA gates a more consistent UI
ClosedPublic
Actions

Authored by epriestley on Jan 29 2019, 10:43 PM.
Tags
None
Referenced Files
F13084786: D20059.diff
Wed, Apr 24, 11:23 PM
Unknown Object (File)
Mon, Apr 22, 10:07 AM
Unknown Object (File)
Fri, Apr 19, 4:09 AM
Unknown Object (File)
Fri, Apr 19, 2:38 AM
Unknown Object (File)
Mon, Apr 8, 3:30 PM
Unknown Object (File)
Thu, Apr 4, 12:03 AM
Unknown Object (File)
Mon, Apr 1, 6:55 AM
Unknown Object (File)
Wed, Mar 27, 5:22 PM
View All 94 Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP13e4aeb59059: Give MFA gates a more consistent UI
Summary

Depends on D20057. Currently, we show an "MFA" message on one of these and an "Error" message on the other, with different icons and colors. Use "MFA" for both, with the MFA icon / color.

Test Plan

Hit both varations, saw more consistency.

Diff Detail

Repository
rP Phabricator
Branch
xmail2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21750
Build 29682: Run Core Tests
Build 29681: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 29 2019, 10:43 PM
Harbormaster completed remote builds in B21750: Diff 47894.Jan 29 2019, 10:45 PM
epriestley requested review of this revision.Jan 29 2019, 10:45 PM
amckinley accepted this revision.Jan 30 2019, 6:39 AM
This revision is now accepted and ready to land.Jan 30 2019, 6:39 AM
Closed by commit rP13e4aeb59059: Give MFA gates a more consistent UI (authored by epriestley). · Explain WhyJan 30 2019, 2:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
handler/
22 lines

Diff 47894

View Options

src/aphront/handler/PhabricatorHighSecurityRequestExceptionHandler.php

Loading...
Phabricator · Built by Phacility