If you go through the accountadmin flow and change nothing, you get an exception about the transaction not having any effect. Instead, let the applyTransactions call continue even on no effect.
Details
Details
- Reviewers
epriestley - Commits
- rPc756bf347617: Fix bin/accountadmin when not making changes
Ran accountadmin without changing anything for an existing user. No longer got an exception about no-effect transactions.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 21628 Build 29487: Run Core Tests Build 29486: arc lint + arc unit
Event Timeline
Comment Actions
In theory, I'd like to wave a magic wand and get rid of this and scripts/user/add_user.php, but it would probably be a bit disruptive for some tiny subset of installs. When we build proper external account importers we might be better able to get away with it.