Fix bin/accountadmin when not making changes
ClosedPublic
Actions

Authored by amckinley on Jan 21 2019, 8:35 PM.

Details

Reviewers

epriestley

Commits

rPc756bf347617: Fix bin/accountadmin when not making changes

Summary

If you go through the accountadmin flow and change nothing, you get an exception about the transaction not having any effect. Instead, let the applyTransactions call continue even on no effect.

Test Plan

Ran accountadmin without changing anything for an existing user. No longer got an exception about no-effect transactions.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

amckinley created this revision.Jan 21 2019, 8:35 PM

Harbormaster completed remote builds in B21628: Diff 47772.Jan 21 2019, 8:37 PM

amckinley requested review of this revision.Jan 21 2019, 8:37 PM

Herald added a subscriber: Korvin. · View Herald TranscriptJan 21 2019, 8:37 PM

epriestley accepted this revision.Jan 21 2019, 8:38 PM

This revision is now accepted and ready to land.Jan 21 2019, 8:38 PM

In theory, I'd like to wave a magic wand and get rid of this and scripts/user/add_user.php, but it would probably be a bit disruptive for some tiny subset of installs. When we build proper external account importers we might be better able to get away with it.

Closed by commit rPc756bf347617: Fix bin/accountadmin when not making changes (authored by amckinley). · Explain WhyJan 21 2019, 8:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

scripts/

user/

account_admin.php

1 line

Diff 47773

View Options

scripts/user/account_admin.php

Fix bin/accountadmin when not making changesClosedPublicActions