Differential D19999

Add setup warnings for "local_infile" (MySQL Server) and "mysql[i].allow_local_infile" (PHP Client)
ClosedPublic
Actions

Authored by epriestley on Jan 18 2019, 5:37 PM.

Details

Reviewers

amckinley

Maniphest Tasks

T13238: Disallow MYSQLI_OPT_LOCAL_INFILE

Commits

rP98bf3a950dcf: Add setup warnings for "local_infile" (MySQL Server) and "mysql[i].

Summary

Ref T13238. Warn users about these horrible options and encourage them to defuse them.

Test Plan

Hit both warnings, fixed the issues, issues went away.

Diff Detail

Repository

rP Phabricator

Branch

infile1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21595
Build 29442: Run Core Tests
Build 29441: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 18 2019, 5:37 PM

Harbormaster completed remote builds in B21592: Diff 47740.Jan 18 2019, 5:39 PM

epriestley requested review of this revision.Jan 18 2019, 5:39 PM

Wordsmithing: the query is "LOCAL INFILE", not "INFILE LOCAL".

Harbormaster completed remote builds in B21595: Diff 47743.Jan 18 2019, 6:03 PM

The blasé discussion in the MySQL documentation about how "yes, this does exactly what it looks like it it does" just kills me.

This revision is now accepted and ready to land.Jan 19 2019, 1:00 AM

Closed by commit rP98bf3a950dcf: Add setup warnings for "local_infile" (MySQL Server) and "mysql[i]. (authored by epriestley). · Explain WhyJan 19 2019, 3:49 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

check/

PhabricatorMySQLSetupCheck.php

28 lines

PhabricatorPHPConfigSetupCheck.php

36 lines

Diff 47743

View Options

src/applications/config/check/PhabricatorMySQLSetupCheck.php