Differential D19977

Don't require "CAN_EDIT" to watch/unwatch a project
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 1:55 PM.

Tags

None

Referenced Files

	F18764726: D19977.diff
	Tue, Oct 7, 7:35 AM

	F18674230: D19977.id.diff
	Thu, Sep 25, 1:43 PM

	F18619691: D19977.diff
	Mon, Sep 15, 3:10 AM

	F18579512: D19977.diff
	Thu, Sep 11, 1:10 AM

	F18569188: D19977.id47703.diff
	Wed, Sep 10, 1:04 AM

	F18569184: D19977.id47679.diff
	Wed, Sep 10, 1:04 AM

	F18566817: D19977.id.diff
	Tue, Sep 9, 2:55 PM

	F18517742: D19977.diff
	Sep 5 2025, 1:52 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP966a93334c85: Don't require "CAN_EDIT" to watch/unwatch a project

Summary

See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan

Before change: tried to watch a project I could not edit, got a policy error.
After change: watched/unwatched a project I could not edit.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 16 2019, 1:55 PM

Harbormaster completed remote builds in B21532: Diff 47679.Jan 16 2019, 1:57 PM

epriestley requested review of this revision.Jan 16 2019, 1:57 PM

amckinley accepted this revision.Jan 16 2019, 5:49 PM

This revision is now accepted and ready to land.Jan 16 2019, 5:49 PM

Closed by commit rP966a93334c85: Don't require "CAN_EDIT" to watch/unwatch a project (authored by epriestley). · Explain WhyJan 16 2019, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

3 lines

Diff 47703

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Don't require "CAN_EDIT" to watch/unwatch a projectClosedPublicActions