Differential D19977

Don't require "CAN_EDIT" to watch/unwatch a project
ClosedPublic
Actions

Authored by epriestley on Jan 16 2019, 1:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 9, 7:22 PM

	Unknown Object (File)
	Sun, Feb 9, 6:55 AM

	Unknown Object (File)
	Sun, Feb 9, 6:55 AM

	Unknown Object (File)
	Sun, Feb 9, 6:55 AM

	Unknown Object (File)
	Sat, Feb 1, 4:34 PM

	Unknown Object (File)
	Tue, Jan 28, 9:46 AM

	Unknown Object (File)
	Sat, Jan 25, 3:11 AM

	Unknown Object (File)
	Sat, Jan 25, 3:11 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rP966a93334c85: Don't require "CAN_EDIT" to watch/unwatch a project

Summary

See T1024. When "CAN_EDIT" became default in T13186, this was missed as an exception.

Watching shouldn't require "CAN_EDIT", so exempt it.

Test Plan

Before change: tried to watch a project I could not edit, got a policy error.
After change: watched/unwatched a project I could not edit.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 16 2019, 1:55 PM

Harbormaster completed remote builds in B21532: Diff 47679.Jan 16 2019, 1:57 PM

epriestley requested review of this revision.Jan 16 2019, 1:57 PM

amckinley accepted this revision.Jan 16 2019, 5:49 PM

This revision is now accepted and ready to land.Jan 16 2019, 5:49 PM

Closed by commit rP966a93334c85: Don't require "CAN_EDIT" to watch/unwatch a project (authored by epriestley). · Explain WhyJan 16 2019, 9:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

3 lines

Diff 47703

View Options

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Don't require "CAN_EDIT" to watch/unwatch a projectClosedPublicActions