Page MenuHomePhabricator

Fix an issue where transactions in mail were always rendered as text
ClosedPublic

Authored by epriestley on Jan 14 2019, 7:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 28, 9:30 AM
Unknown Object (File)
Tue, May 27, 11:27 AM
Unknown Object (File)
Wed, May 7, 9:01 AM
Unknown Object (File)
Apr 18 2025, 3:20 AM
Unknown Object (File)
Apr 16 2025, 1:23 AM
Unknown Object (File)
Apr 16 2025, 1:22 AM
Unknown Object (File)
Apr 16 2025, 1:22 AM
Unknown Object (File)
Apr 15 2025, 5:44 PM
Subscribers
None

Details

Summary

Fixes T12921. Currently, we call getTitleForHTMLMail(), but that calls getTitleForMail() which forces us into text rendering mode.

Instead, have getTitleForHTML/TextMail() force the rendering mode, then call getTitleForMail() with the desired rendering mode.

This causes stories like "epriestely added dependent tasks: x, y." to appear as links in email instead of plain text.

Test Plan

Used bin/mail show-outbound --id ... --dump-html > out.html to verify HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Slightly simpler implementation.
This revision is now accepted and ready to land.Jan 16 2019, 2:10 AM
This revision was automatically updated to reflect the committed changes.