Page MenuHomePhabricator

Fix an issue where transactions in mail were always rendered as text
ClosedPublic

Authored by epriestley on Jan 14 2019, 7:31 PM.

Details

Summary

Fixes T12921. Currently, we call getTitleForHTMLMail(), but that calls getTitleForMail() which forces us into text rendering mode.

Instead, have getTitleForHTML/TextMail() force the rendering mode, then call getTitleForMail() with the desired rendering mode.

This causes stories like "epriestely added dependent tasks: x, y." to appear as links in email instead of plain text.

Test Plan

Used bin/mail show-outbound --id ... --dump-html > out.html to verify HTML mail.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.