Page MenuHomePhabricator

Remove Twilio-PHP API external
ClosedPublic

Authored by epriestley on Wed, Jan 2, 3:16 AM.

Details

Summary

Ref T920. D19937 provides about 100 lines of code which can do essentially everything here; throw out the trillion lines of full external API stuff.

(I am generally not sure why everyone writes API libraries like this instead of like D19937.)

Test Plan

Send SMS messages with D19937, so I don't think we need any of this code anymore. This code is techncially reachable through some pathways like bin/sms, but won't be for long.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Wed, Jan 2, 3:16 AM

(This is just git rm -r externals/twilio-php.)

epriestley requested review of this revision.Wed, Jan 2, 3:17 AM
This revision is now accepted and ready to land.Thu, Jan 3, 12:24 AM
This revision was automatically updated to reflect the committed changes.