Page MenuHomePhabricator

Remove Twilio-PHP API external
ClosedPublic

Authored by epriestley on Jan 2 2019, 3:16 AM.
Tags
None
Referenced Files
F13195639: D19938.diff
Sun, May 12, 10:32 PM
F13179644: D19938.diff
Wed, May 8, 9:20 PM
Unknown Object (File)
Tue, May 7, 4:29 AM
Unknown Object (File)
Mon, May 6, 12:36 AM
Unknown Object (File)
Sat, May 4, 6:55 PM
Unknown Object (File)
Fri, May 3, 10:30 AM
Unknown Object (File)
Wed, May 1, 12:22 AM
Unknown Object (File)
Sat, Apr 20, 4:24 PM
Subscribers

Details

Summary

Ref T920. D19937 provides about 100 lines of code which can do essentially everything here; throw out the trillion lines of full external API stuff.

(I am generally not sure why everyone writes API libraries like this instead of like D19937.)

Test Plan

Send SMS messages with D19937, so I don't think we need any of this code anymore. This code is techncially reachable through some pathways like bin/sms, but won't be for long.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable