Paths

Table of Contentst

Differential D19882

Fix construction of two new qsprintf() exceptions
ClosedPublic
Actions

Authored by epriestley on Dec 13 2018, 7:01 PM.

Tags

None

Referenced Files

	F14083674: D19882.id.diff
	Sat, Nov 23, 5:12 AM

	F14082260: D19882.diff
	Fri, Nov 22, 11:14 PM

	Unknown Object (File)
	Tue, Nov 19, 3:34 AM

	Unknown Object (File)
	Mon, Nov 4, 5:09 PM

	Unknown Object (File)
	Wed, Oct 30, 8:32 AM

	Unknown Object (File)
	Sun, Oct 27, 12:29 PM

	Unknown Object (File)
	Thu, Oct 24, 12:41 PM

	Unknown Object (File)
	Oct 16 2024, 3:47 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()
T13222: 2018 Week 48-51 Bonus Content

Commits

rPHUa537ba03c994: (stable) Promote 2018 Week 50
rPHUcad1985726c9: Fix construction of two new qsprintf() exceptions

Summary

Ref T13222. Ref T13217. These exception signatures aren't quite right, they should take $query as the first parameter.

Test Plan

Misused %P. Before: error about exception construction. After: useful exception.

Diff Detail

Repository

rPHU libphutil

Branch

mfa3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21329
Build 29024: Run Core Tests
Build 29023: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 13 2018, 7:01 PM

Harbormaster completed remote builds in B21329: Diff 47478.Dec 13 2018, 7:02 PM

epriestley requested review of this revision.Dec 13 2018, 7:02 PM

amckinley accepted this revision.Dec 13 2018, 7:49 PM

This revision is now accepted and ready to land.Dec 13 2018, 7:49 PM

Closed by commit rPHUcad1985726c9: Fix construction of two new qsprintf() exceptions (authored by epriestley). · Explain WhyDec 13 2018, 8:22 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

xsprintf/

qsprintf.php

2 lines

Diff 47478

View Options

Fix construction of two new qsprintf() exceptionsClosedPublicActions