Differential D19872

Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 6:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 11:02 AM

	Unknown Object (File)
	Sun, Feb 9, 1:42 PM

	Unknown Object (File)
	Sun, Feb 9, 1:42 PM

	Unknown Object (File)
	Sun, Feb 9, 1:41 PM

	Unknown Object (File)
	Sun, Feb 9, 1:41 PM

	Unknown Object (File)
	Sun, Feb 9, 2:50 AM

	Unknown Object (File)
	Tue, Feb 4, 1:26 AM

	Unknown Object (File)
	Mon, Feb 3, 2:35 AM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Maniphest Tasks

T13217: Upgrading: Hardening of qsprintf()

Commits

rP2814d340367c: Fix a stray qsprintf() in the Herald rules engine when recording rule…

Summary

Ref T13217. See PHI1006.

Test Plan

Touched an object with associated Herald rules.

Diff Detail

Repository

rP Phabricator

Branch

query2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21306
Build 28988: Run Core Tests
Build 28987: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 12 2018, 6:58 PM

Harbormaster completed remote builds in B21306: Diff 47453.Dec 12 2018, 7:00 PM

epriestley requested review of this revision.Dec 12 2018, 7:00 PM

amckinley accepted this revision.Dec 12 2018, 7:15 PM

This revision is now accepted and ready to land.Dec 12 2018, 7:15 PM

Closed by commit rP2814d340367c: Fix a stray qsprintf() in the Herald rules engine when recording rule… (authored by epriestley). · Explain WhyDec 12 2018, 7:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

engine/

HeraldEngine.php

4 lines

Diff 47453

View Options

src/applications/herald/engine/HeraldEngine.php

Fix a stray qsprintf() in the Herald rules engine when recording rule application to objectsClosedPublicActions