Paths

Table of Contentst

Differential D19870

Fix an issue with creating tasks directly into workboard columns
ClosedPublic
Actions

Authored by epriestley on Dec 12 2018, 4:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 24, 1:46 PM

	Unknown Object (File)
	Sat, Nov 23, 5:11 AM

	Unknown Object (File)
	Mon, Nov 11, 5:11 AM

	Unknown Object (File)
	Thu, Nov 7, 6:42 PM

	Unknown Object (File)
	Thu, Nov 7, 6:21 PM

	Unknown Object (File)
	Thu, Nov 7, 5:29 PM

	Unknown Object (File)
	Oct 3 2024, 5:02 AM

	Unknown Object (File)
	Oct 3 2024, 3:10 AM

Subscribers

None

Details

Reviewers

Commits

rP66ff6d4a2ca0: Fix an issue with creating tasks directly into workboard columns

Summary

See https://discourse.phabricator-community.org/t/tasks-created-via-workboard-column-menu-are-moved-to-wrong-column/2200. The recent setIsConduitOnly() / setIsFormField() change (in D19842) disrupted creating tasks directly into a column from the workboard UI.

This field is a form field, it just doesn't render a visible control.

Test Plan

Created a task directly into a workboard column. Before: column selection ignored. After: appeared in correct column.
Used "move on workboard" comment action.
Edited tasks; edited forms for tasks. Didn't observe any collateral damage (weird "Column" fields being present).

Diff Detail

Repository

Branch

column1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21301
Build 28981: Run Core Tests
Build 28980: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 12 2018, 4:25 PM

epriestley edited the summary of this revision. (Show Details)Dec 12 2018, 4:26 PM

epriestley mentioned this in D19842: Allow "Change Subtype" to be selected from the comment action stack.

Harbormaster completed remote builds in B21301: Diff 47448.Dec 12 2018, 4:26 PM

epriestley requested review of this revision.Dec 12 2018, 4:26 PM

amckinley accepted this revision.Dec 12 2018, 4:35 PM

This revision is now accepted and ready to land.Dec 12 2018, 4:35 PM

Closed by commit rP66ff6d4a2ca0: Fix an issue with creating tasks directly into workboard columns (authored by epriestley). · Explain WhyDec 12 2018, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

editor/

ManiphestEditEngine.php

4 lines

Diff 47448

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...