Page MenuHomePhabricator

Fix some straggling qsprintf() warnings in repository import
ClosedPublic

Authored by epriestley on Dec 12 2018, 1:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 17, 6:23 AM
Unknown Object (File)
Sun, Nov 10, 3:50 AM
Unknown Object (File)
Sat, Nov 9, 3:52 AM
Unknown Object (File)
Sat, Nov 9, 2:45 AM
Unknown Object (File)
Tue, Nov 5, 12:58 AM
Unknown Object (File)
Wed, Oct 30, 6:44 AM
Unknown Object (File)
Sun, Oct 27, 11:55 PM
Unknown Object (File)
Oct 14 2024, 2:25 PM
Subscribers
None

Details

Summary

Ref T13217. See https://discourse.phabricator-community.org/t/unsafe-raw-string-warnings-while-importing-git-commits/2191.

Hunt down and fix two more qsprintf() things.

I just converted the "performance optimization" into a normal, safe call since we're dealing with far less SVN stuff nowadays and the actual issue has been lost in the mists of time. If it resurfaces, we can take another look.

Test Plan

Imported some commits, no longer saw these warnings in the daemon logs.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable