Differential D19867

Make viewing a user's profile page clear notifications about that user
ClosedPublic
Actions

Authored by epriestley on Dec 11 2018, 12:15 AM.

Details

Reviewers

amckinley

Maniphest Tasks

T13222: 2018 Week 48-51 Bonus Content

Commits

rP0e067213fbb1: Make viewing a user's profile page clear notifications about that user

Summary

Ref T13222. See PHI996. This is a general correctness improvement, but also allows you to clear test notifications by clicking on them (since their default destination is the recipient's profile page).

Test Plan

Clicked a test notification, got taken to my profile page, saw notification marked as read.

Diff Detail

Repository

rP Phabricator

Branch

notify6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21297
Build 28974: Run Core Tests
Build 28973: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 11 2018, 12:15 AM

Harbormaster completed remote builds in B21297: Diff 47444.Dec 11 2018, 12:17 AM

epriestley requested review of this revision.Dec 11 2018, 12:17 AM

amckinley accepted this revision.Dec 11 2018, 12:26 AM

This revision is now accepted and ready to land.Dec 11 2018, 12:26 AM

Closed by commit rP0e067213fbb1: Make viewing a user's profile page clear notifications about that user (authored by epriestley). · Explain WhyDec 11 2018, 12:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileViewController.php

4 lines

Diff 47444

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Make viewing a user's profile page clear notifications about that userClosedPublicActions