Without an existing root document, Phriction shows a nice little "fake" document as the landing page, which has its own nice "Edit this document" button. When showing that page, don't also render the standard "New Document" breadcrumb in the top right. That button always prompts first for a slug name, which is silly when the root document doesn't exist (because the slug name is required to be '').
Details
Details
Loaded Phriction with and without a root document.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- phriction-root (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 21282 Build 28955: Run Core Tests Build 28954: arc lint + arc unit
Event Timeline
Comment Actions
Maybe consider setIsWelcomeDocument() or setHideNewDocumentButton(), on first read it was a little surprising that the effect of showWelcomeDocument isn't to cause a welcome document to be shown.