Page MenuHomePhabricator

Allow the "Create Subtask" workflow to prompt for a subtype selection, and prepare for customizable options

Authored by epriestley on Dec 6 2018, 7:09 PM.
Referenced Files
Unknown Object (File)
Thu, Aug 4, 7:10 AM
Unknown Object (File)
Thu, Aug 4, 3:36 AM
Unknown Object (File)
Sat, Jul 30, 1:34 AM
Unknown Object (File)
Mon, Jul 25, 11:03 AM
Unknown Object (File)
Sun, Jul 24, 3:10 PM
Unknown Object (File)
Sat, Jul 23, 2:09 PM
Unknown Object (File)
Fri, Jul 22, 6:03 AM
Unknown Object (File)
Thu, Jul 21, 11:49 AM



Ref T13222. Ref T12588. See PHI683. Currently, "Create Subtask" always uses the first edit form that the user has access to for the same task subtype. (For example, if you "Create Subtask" from a "Bug", you get the first edit form for "Bugs".)

I didn't want to go too crazy with the initial subtype implementation, but it seems like we're generally on firm ground and it's working fairly well: user requests are for more flexibility in using the system as implemented, not changes to the system or confusion/difficulty with any of the tradeoffs. Thus, I'm generally comfortable continuing to build it out in the same direction. To improve flexibility, I want to make the options from "Create Subtask" more flexible/configurable.

I plan to let you specify that a given subtype (say, "Quest") prompts you with creation options for a set of other subtypes (say, "Objective"), or prompts you with a particular set of forms.

If we end up with a single option, we just go into the current flow (directly to the edit form). If we end up with more than one option, we prompt the user to choose between them.

This change is a first step toward this:

  • When building "Create Subtask", query for multiple forms.
  • The default behavior is now "prompt user to choose among create forms of the same subtype". Previously, it was "use the first edit form of the same subtype". This is a behavioral change.
  • The next change will make the selected forms configurable.
  • (I also plan to make the dialog itself less rough.)
Test Plan

Screen Shot 2018-12-06 at 10.57.08 AM.png (1×1 px, 155 KB)

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 21258
Build 28918: Run Core Tests
Build 28917: arc lint + arc unit