Paths

Table of Contentst

Differential D19852

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic
Actions

Authored by epriestley on Dec 6 2018, 4:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 7:41 PM

	Unknown Object (File)
	Wed, Nov 20, 10:35 AM

	Unknown Object (File)
	Fri, Nov 15, 11:48 PM

	Unknown Object (File)
	Tue, Nov 12, 1:24 AM

	Unknown Object (File)
	Mon, Nov 11, 5:11 AM

	Unknown Object (File)
	Fri, Nov 8, 5:51 AM

	Unknown Object (File)
	Mon, Nov 4, 5:11 AM

	Unknown Object (File)
	Mon, Nov 4, 5:10 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T12588: create subtask side menu to allow creation of subtasks of different types to the parent task
T13222: 2018 Week 48-51 Bonus Content

Commits

rPf0eefdd0b58b: Replace the informal "array" subtype map with a more formal "SubtypeMap" object

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository

Branch

subtype1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 21257
Build 28916: Run Core Tests
Build 28915: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 6 2018, 4:15 PM

Harbormaster completed remote builds in B21257: Diff 47406.Dec 6 2018, 4:17 PM

epriestley requested review of this revision.Dec 6 2018, 4:17 PM

epriestley edited the summary of this revision. (Show Details)Dec 6 2018, 6:59 PM

epriestley added a task: T12588: create subtask side menu to allow creation of subtasks of different types to the parent task.

amckinley accepted this revision.Dec 8 2018, 12:02 AM

This revision is now accepted and ready to land.Dec 8 2018, 12:02 AM

Closed by commit rPf0eefdd0b58b: Replace the informal "array" subtype map with a more formal "SubtypeMap" object (authored by epriestley). · Explain WhyDec 10 2018, 12:37 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

applications/

maniphest/

query/

ManiphestTaskSearchEngine.php

2 lines

storage/

ManiphestTask.php

2 lines

ManiphestTransaction.php

5 lines

typeahead/

ManiphestTaskSubtypeDatasource.php

2 lines

view/

ManiphestTaskListView.php

3 lines

transactions/

controller/

PhabricatorEditEngineConfigurationSubtypeController.php

3 lines

editengine/

PhabricatorEditEngineSubtype.php

2 lines

PhabricatorEditEngineSubtypeMap.php

42 lines

editor/

PhabricatorApplicationTransactionEditor.php

2 lines

PhabricatorEditEngineConfigurationEditor.php

2 lines

engineextension/

PhabricatorSubtypeEditEngineExtension.php

4 lines

Diff 47406

src/__phutil_library_map__.php

Loading...

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

Loading...

src/applications/maniphest/storage/ManiphestTask.php

Loading...

src/applications/maniphest/storage/ManiphestTransaction.php

Loading...

src/applications/maniphest/typeahead/ManiphestTaskSubtypeDatasource.php

Loading...

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...

src/applications/transactions/controller/PhabricatorEditEngineConfigurationSubtypeController.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngineSubtype.php

Loading...

src/applications/transactions/editengine/PhabricatorEditEngineSubtypeMap.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php

Loading...

src/applications/transactions/engineextension/PhabricatorSubtypeEditEngineExtension.php

Loading...