Page MenuHomePhabricator

Replace the informal "array" subtype map with a more formal "SubtypeMap" object
ClosedPublic

Authored by epriestley on Dec 6 2018, 4:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 9, 11:38 AM
Unknown Object (File)
Thu, Aug 4, 3:35 AM
Unknown Object (File)
Tue, Jul 26, 2:44 AM
Unknown Object (File)
Sat, Jul 23, 2:11 PM
Unknown Object (File)
Fri, Jul 22, 7:40 AM
Unknown Object (File)
Jul 14 2022, 11:03 PM
Unknown Object (File)
Jul 9 2022, 4:39 AM
Unknown Object (File)
Jul 7 2022, 2:37 PM
Subscribers
None

Details

Summary

Ref T13222. Ref T12588. See PHI683. To make "Create Subtask..." fancier, we need slightly more logic around subtype maps. Upgrade the plain old array into a proper object so it can have relevant methods, notably "get a list of valid child subtypes for some parent subtype".

Test Plan

Created and edited tasks, changed task subtypes. Grepped for affected symbols (newEditEngineSubtypeMap, newSubtypeMap).

Diff Detail

Repository
rP Phabricator
Branch
subtype1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21257
Build 28916: Run Core Tests
Build 28915: arc lint + arc unit