Page MenuHomePhabricator
Differential D19851

Add an "availaiblity" attachment for user.search
ClosedPublic
Actions

Authored by epriestley on Dec 5 2018, 8:48 PM.
Tags
None
Referenced Files
F14091779: D19851.diff
Mon, Nov 25, 2:17 AM
Unknown Object (File)
Thu, Nov 21, 8:01 PM
Unknown Object (File)
Mon, Nov 18, 8:43 AM
Unknown Object (File)
Fri, Nov 15, 7:05 AM
Unknown Object (File)
Mon, Nov 11, 6:37 PM
Unknown Object (File)
Mon, Nov 11, 9:35 AM
Unknown Object (File)
Sun, Nov 10, 2:22 AM
Unknown Object (File)
Wed, Nov 6, 2:18 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13222: 2018 Week 48-51 Bonus Content
Commits
rP1e4bdc39a11b: Add an "availaiblity" attachment for user.search
Summary

Ref T13222. See PHI990. The older user.query supports availability information, but it isn't currently available in a modern way. Make it available.

Test Plan

Screen Shot 2018-12-05 at 12.45.05 PM.png (1×2 px, 202 KB)

Diff Detail

Repository
rP Phabricator
Branch
avail1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 21254
Build 28912: Run Core Tests
Build 28911: arc lint + arc unit

Event Timeline

epriestley created this revision.Dec 5 2018, 8:48 PM
Harbormaster completed remote builds in B21253: Diff 47402.Dec 5 2018, 8:49 PM
epriestley requested review of this revision.Dec 5 2018, 8:49 PM
epriestley updated this revision to Diff 47403.Dec 5 2018, 8:51 PM
  • Return an explicit "available", not null, for available users.
Harbormaster completed remote builds in B21254: Diff 47403.Dec 5 2018, 8:52 PM
amckinley accepted this revision.Dec 7 2018, 11:33 PM
This revision is now accepted and ready to land.Dec 7 2018, 11:33 PM
Closed by commit rP1e4bdc39a11b: Add an "availaiblity" attachment for user.search (authored by epriestley). · Explain WhyDec 10 2018, 12:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
people/
engineextension/
46 lines
storage/
5 lines

Diff 47403

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/people/engineextension/PhabricatorPeopleAvailabilitySearchEngineAttachment.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility