Page MenuHomePhabricator

Remove defunct "metamta.herald.show-hints" Config option
ClosedPublic

Authored by epriestley on Sat, Nov 24, 2:34 PM.

Details

Summary

Ref T13216. See PHI985. This config option once controlled adding a Herald transcript link to email. However, this was never implemented in a generic way and was removed from revisions in D8459 and from commits in D10705. No one has noticed or asked for this option for several years, so this is probably a good opportunity to simplify the software and reduce the total amount of configuration.

If we did want to pursue this in the future, I'd generally prefer to make it part of the mail detail page (/mail/detail/12345/) anyway.

Test Plan

Grepped for metamta.herald.show-hints and addHeraldSection(), got no hits for either.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

epriestley created this revision.Sat, Nov 24, 2:34 PM
epriestley requested review of this revision.Sat, Nov 24, 2:35 PM
amckinley accepted this revision.Mon, Nov 26, 4:51 PM
This revision is now accepted and ready to land.Mon, Nov 26, 4:51 PM
This revision was automatically updated to reflect the committed changes.