Page MenuHomePhabricator

Remove defunct "metamta.herald.show-hints" Config option
ClosedPublic

Authored by epriestley on Nov 24 2018, 2:34 PM.
Tags
None
Referenced Files
F15308869: D19833.id47375.diff
Thu, Mar 6, 6:44 AM
Unknown Object (File)
Mon, Mar 3, 7:54 AM
Unknown Object (File)
Mon, Feb 24, 10:05 PM
Unknown Object (File)
Sun, Feb 16, 6:14 PM
Unknown Object (File)
Sun, Feb 9, 7:17 PM
Unknown Object (File)
Sun, Feb 9, 6:41 AM
Unknown Object (File)
Sun, Feb 9, 6:41 AM
Unknown Object (File)
Sun, Feb 9, 6:41 AM
Subscribers
None

Details

Summary

Ref T13216. See PHI985. This config option once controlled adding a Herald transcript link to email. However, this was never implemented in a generic way and was removed from revisions in D8459 and from commits in D10705. No one has noticed or asked for this option for several years, so this is probably a good opportunity to simplify the software and reduce the total amount of configuration.

If we did want to pursue this in the future, I'd generally prefer to make it part of the mail detail page (/mail/detail/12345/) anyway.

Test Plan

Grepped for metamta.herald.show-hints and addHeraldSection(), got no hits for either.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable